Fix idempotent table cache update handling#17959
Merged
JackieTien97 merged 1 commit intoJun 17, 2026
Merged
Conversation
JackieTien97
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes DataNode table cache update handling idempotent when a commit or rollback update request is repeated or arrives after the pre-update entry has already been cleared. commitUpdateTable previously read the pre-update table and wrote it into a ConcurrentHashMap without checking for null, so a delayed duplicate commit could throw an NPE after the entry was already handled. The change treats missing or cleared pre-update entries as already handled and makes removeTableFromPreUpdateMap tolerant of absent entries. Tests: mvn -pl iotdb-core/datanode -am -Dtest=DataNodeTableCacheTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.skip=true -Dcheckstyle.skip=true test -DskipITs; mvn -pl iotdb-core/datanode -DskipTests -DskipITs spotless:check checkstyle:check.