added iterator dst tests#17961
Open
Lexert19 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For #12537
This PR does not fully fix the TimeRangeIterator timezone bug, it adds reproducible tests that document the current behavior.
Changes in TimeRangeIteratorTest:
This test is marked @ignore on purpose.
org.apache.tsfile.utils.TimeDuration treats a day as a fixed physical duration of 86400000ms, not a calendar day in the given ZoneId. Because of that, daily windows drift on 23h/25h DST days and on historical offset changes.
The DateTimeUtils.toZoneOffset(ZoneId zoneId) fix has been moved to a separate issue.
This PR has:
for an unfamiliar reader.
for code coverage.