Subscription: improve WAL replay gap observability - #18377
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aggregate unreadable retained WAL logs
Downgrade per-file WAL open failures to DEBUG and emit one WARN summary when a replay scan is exhausted. The summary includes the WAL directory, skipped file count, first/last file, and the first concise error without repeating a stack trace for every file.
Report unavailable replay ranges
Detect discontinuities between the expected subscription search index and the next retained WAL entry. Record the skipped entry count only when the replay cursor advances, log the unavailable range and cumulative count, and include
walGapSkippedEntriesin periodic queue statistics.This makes bounded WAL-retention loss visible even when the current lag later returns to zero.
Verification
ProgressWALIteratorTest: 8 tests passedConsensusPrefetchingQueueTest#testWalReplayCountsOnlyUnavailableSearchIndexes: passed-P with-zh-localeThis PR has:
Key changed/added classes
ProgressWALIteratorConsensusPrefetchingQueue