feat: Add float32 zero-copy angle encoding in Python bindings (single sample)#1264
Open
viiccwen wants to merge 9 commits intoapache:mainfrom
Open
feat: Add float32 zero-copy angle encoding in Python bindings (single sample)#1264viiccwen wants to merge 9 commits intoapache:mainfrom
viiccwen wants to merge 9 commits intoapache:mainfrom
Conversation
viiccwen
requested review from
400Ping,
guan404ming and
ryankert01
as code owners
viiccwen
changed the title
rich7420
reviewed
Apr 19, 2026
Contributor
rich7420
left a comment
rich7420
left a comment
There was a problem hiding this comment.
thanks for the patch! sorry for the late review:
viiccwen
force-pushed
the
feature/angle-f32-python-binding-single
branch
from
9308194 to
f815e74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #1250
Changes
Why
QDP core already supports single-sample angle encoding from CUDA
float32buffers, but the Python binding did not expose that path. This PR adds the
Python-side support while keeping batch CUDA angle inputs on
float64.How
float32angle tensors through the dedicated zero-copy angleGPU-pointer path
float32support limited to 1D single-sample tensorsamplitudeandanglefloat64precision so thecomparison matches the reference dtype
Checklist