Skip to content

issue:983 fix create-from-project / preserveCData / multi-modules#984

Open
lalmeras wants to merge 1 commit intoapache:masterfrom
kobalt-fr:issue-983-preserveCData
Open

issue:983 fix create-from-project / preserveCData / multi-modules#984
lalmeras wants to merge 1 commit intoapache:masterfrom
kobalt-fr:issue-983-preserveCData

Conversation

@lalmeras
Copy link

Related to #983

When a multi-module project is used with create-from-project with preserveCData, dependencies between modules are broken.

For the following hierarchy :

  • A
    • B
    • C -> B

The built archetype replace B dependency in C module with a A dependency.

This commit adds an integration test triggering the issue and a fix.

Fix restore correctly the ${parentArtifactId} value:

  • before: previous module artifactId is used (so B module setup ${parentArtifactId} B value)
  • after: original value when entering the method is restored (so B module setup ${parentArticatId} A value)

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. -> I only write an integration test
  • Run mvn verify to make sure basic checks pass. -> mvn -Prun-its verify
  • You have run the integration tests successfully (mvn -Prun-its verify).

[x] If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

When a multi-module project is used with create-from-project with preserveCData,
dependencies between modules are broken.

For the following hierarchy :
* A
  * B
  * C -> B

The built archetype replace B dependency in C module with a A dependency.

This commit adds an integration test triggering the issue and a fix.

Fix restore correctly the ${parentArtifactId} value:
* before: previous module artifactId is used (so B module setup
  ${parentArtifactId} B value)
* after: original value when entering the method is restored (so B
  module setup ${parentArticatId} A value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant