issue:983 fix create-from-project / preserveCData / multi-modules#984
Open
lalmeras wants to merge 1 commit intoapache:masterfrom
Open
issue:983 fix create-from-project / preserveCData / multi-modules#984lalmeras wants to merge 1 commit intoapache:masterfrom
lalmeras wants to merge 1 commit intoapache:masterfrom
Conversation
When a multi-module project is used with create-from-project with preserveCData,
dependencies between modules are broken.
For the following hierarchy :
* A
* B
* C -> B
The built archetype replace B dependency in C module with a A dependency.
This commit adds an integration test triggering the issue and a fix.
Fix restore correctly the ${parentArtifactId} value:
* before: previous module artifactId is used (so B module setup
${parentArtifactId} B value)
* after: original value when entering the method is restored (so B
module setup ${parentArticatId} A value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #983
When a multi-module project is used with create-from-project with preserveCData, dependencies between modules are broken.
For the following hierarchy :
The built archetype replace B dependency in C module with a A dependency.
This commit adds an integration test triggering the issue and a fix.
Fix restore correctly the ${parentArtifactId} value:
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn verifyto make sure basic checks pass. -> mvn -Prun-its verifymvn -Prun-its verify).[x] If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.