Conversation
elharo
changed the title
|
The tests are failing, because some of the introduced plugin options are not available with all JDK vendors. |
…endors and versions support this option
|
Hi @Til7701 -- you are right, CDS is a hotspot-specific thing, but other Java vendors like IBM may chose to replace hotspot and its CDS with something else -- like Eclipse OpenJ9 as Memory-Management and GC implementation with SCC (shared class cache) as an almost equivalent implementation. |
pom.xml
Outdated
| <!-- This test does not work for all jdk vendors and versions --> | ||
| <pomExclude>cli-options/generate-cds-archive/pom.xml</pomExclude> |
There was a problem hiding this comment.
Can you move the exclusion into a profile?
The profile could get activated by the existence of the property openj9.compiler or if the property java.vm.vendor equals Eclipse OpenJ9 or if java.vendor equals IBM Corporation.
There was a problem hiding this comment.
I added profiles for the exclusion. I had to create one for each, since Maven cannot activate a profile based on multiple properties.
|
OK, one more thing. The option The files you added (e.g. |
# Conflicts: # src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
Maran23
left a comment
Maran23
left a comment
There was a problem hiding this comment.
This is a nice addition I also really would like to use!
The tests follow the pattern of the existing ones. So look good to me too.
Note that I'm not an Maven Plugin Expert. But the Mojo code (and resulting JLink command) look fine. Tests follow the pattern of the existing tests. I have 2 comments here.
| <url>http://maven.apache.org</url> | ||
| <description>Test JLink CLI Options --generate-cds-archive.</description> | ||
| <properties> | ||
| <maven.compiler.source>17</maven.compiler.source> |
There was a problem hiding this comment.
You can use the single maven.compiler.release instead of source and target here and in the other pom.xmls.
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.8.0</version> | ||
| <configuration> |
There was a problem hiding this comment.
I don't think this is needed when we set the release version above? (also in the other pom.xml)
3 participants
Fixes #602
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without
pulling in other changes.
[#<num>] - Fixes bug in ApproximateQuantiles,where you replace
#<num>with the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
Description
This PR add support for the JLink options
--generate-cds-archiveand--order-resources.Additionally, it adds the ability to supply additional args to JLink to support undocumented plugins. See #602 for a list of those.