XMLEncode: encode illegal XML control characters#391
Open
elharo wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLEncode.xmlEncodeTextAsPCDATA()passes characters in the range U+0000–U+001F (excluding TAB, LF, CR) through unencoded in thedefaultbranch of its switch statement. These characters are illegal in XML 1.0 and cause XML parsers to reject the output.Additionally,
needsEncoding()only checked for&and<, so text containing only control characters was written directly without reaching the encoding method at all.Fix:
xmlEncodeTextAsPCDATA(), thedefaultcase now encodes illegal control chars as&#xHH;numeric character referencesneedsEncoding(), added a check for illegal control chars so they're routed through the encoding pathFixes #390