Xpp3DomBuilder.createXmlReader: remove thread-unsafe system property manipulation#393
Open
elharo wants to merge 3 commits into
Open
Xpp3DomBuilder.createXmlReader: remove thread-unsafe system property manipulation#393elharo wants to merge 3 commits into
elharo wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xpp3DomBuilder.createXmlReader()clears and restores the globalorg.xml.sax.driversystem property without synchronization (lines 119-129). In a multi-threaded environment like Maven parallel builds, one thread's clear/restore sequence interferes with other threads' reads of the same property. The code's own comment acknowledges: "There's a 'slight' problem with this an parallel maven: It does not work ;)"The method already tries to directly instantiate
com.sun.org.apache.xerces.internal.parsers.SAXParserfirst — which succeeds on all Oracle/OpenJDK JVMs. The system property manipulation fallback is both unnecessary and harmful.Fix: Removed the system property manipulation entirely. If the direct instantiation fails, falls through to
XMLReaderFactory.createXMLReader()without modifying any global state.Fixes #392