Xpp3DomWriter: add explicit null check for dom parameter#397
Closed
elharo wants to merge 1 commit into
Closed
Conversation
desruisseaux
reviewed
Jul 1, 2026
| * @throws IOException if writing fails | ||
| */ | ||
| public static void write(XMLWriter xmlWriter, Xpp3Dom dom, boolean escape) throws IOException { | ||
| Objects.requireNonNull(dom, "dom must not be null"); |
There was a problem hiding this comment.
Is it really solving the problem described in the issue? The next line is dom.getName(), therefore a NullPointerException would happen there anyway. The stack trace produced by Objects will be even deeper (a little bit) than the stack trace produced by the NullPointerException on the next line.
Contributor
Author
There was a problem hiding this comment.
makese sense. thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All public
writemethods accept anXpp3Dom domparameter without null checks. Passingnullthrows aNullPointerExceptiondeep inside the delegation chain (atdom.getName()in thewrite(XMLWriter, Xpp3Dom, boolean)method), producing a confusing stack trace for callers.Fix: Added
Objects.requireNonNull(dom, "dom must not be null")at the entry to the sharedwrite(XMLWriter, Xpp3Dom, boolean)method, so callers get a clear message immediately.Fixes #396