Skip to content

Updated Go Lexer/Parser for Go Lang 1.20 #7269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lkishalmi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated Go Lexer/Parser for Go Lang 1.20 #7269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ide/go.lang/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ import java.util.List;]]></replacevalue>
replace="\1 grammar \2;${golang.additionalheader}"
flags="g"
>
<fileset dir="${golang.outdir}" includes="GoParser.g4 GoLexer.g4" />
<fileset dir="${golang.outdir}/g4" includes="GoParser.g4 GoLexer.g4" />
</replaceregexp>
</target>

Expand Down
2,790 changes: 0 additions & 2,790 deletions ide/go.lang/nbproject/org-netbeans-modules-go-lang.sig
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions ide/go.lang/nbproject/project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
# under the License.
javac.source=1.8

# As of 2nd Jan 2023, we use the Grammar from:
# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang
# As of 14th April 2024, we use the Grammar from:
# https://github.com/antlr/grammars-v4/tree/bcc9ec1b35e4ede2f90abdb8713a56315a634a92/golang
#
golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d
golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92

# Simple language update can result too many signature changes in the generated code.
sigtest.skip.gen=true
Copy link
Copy Markdown
Contributor

@matthiasblaesing matthiasblaesing Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop the pretense that this is module has an API and require that users make dependencies implementation dependencies?

Copy link
Copy Markdown
Member

@neilcsmith-net neilcsmith-net Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Although I'm also curious why this is a module at all?

Loading