Skip to content

Fix env files hints options panel registration#9352

Open
mbien wants to merge 1 commit intoapache:deliveryfrom
mbien:env-hints-panel-fix
Open

Fix env files hints options panel registration#9352
mbien wants to merge 1 commit intoapache:deliveryfrom
mbien:env-hints-panel-fix

Conversation

@mbien
Copy link
Copy Markdown
Member

@mbien mbien commented Apr 17, 2026

panel was already registered via layer.xml.

Followup to #9265

fixes #9349

@mbien mbien added this to the NB30 milestone Apr 17, 2026
@mbien mbien added Editor UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Apr 17, 2026
@mbien mbien requested review from haidubogdan and troizet April 17, 2026 17:37
Copy link
Copy Markdown
Contributor

@haidubogdan haidubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ... sorry, for the miss.

@neilcsmith-net neilcsmith-net added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Apr 18, 2026
@neilcsmith-net
Copy link
Copy Markdown
Member

neilcsmith-net commented Apr 18, 2026

Thanks for looking at this, but shouldn't it be targetting delivery?!

Temporary labelling so we don't get in a tangle.

@mbien mbien changed the base branch from master to delivery April 18, 2026 14:18
@mbien
Copy link
Copy Markdown
Member Author

mbien commented Apr 18, 2026

thanks for checking. I did base the branch on delivery but forgot to set it at the PR level. Probably not worth triggering CI again for this.

@neilcsmith-net neilcsmith-net removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Apr 18, 2026
@troizet
Copy link
Copy Markdown
Collaborator

troizet commented Apr 19, 2026

Unfortunately, nothing has changed. I tried the artifact from this pull request. I also tried building from your branch.

@mbien mbien marked this pull request as draft April 19, 2026 15:26
panel was already registered via layer.xml
@mbien mbien force-pushed the env-hints-panel-fix branch from 7e59bdd to 8146cc1 Compare April 19, 2026 16:18
@mbien mbien marked this pull request as ready for review April 19, 2026 16:18
@mbien
Copy link
Copy Markdown
Member Author

mbien commented Apr 19, 2026

the panel was registered twice, kept it in the layer and removed the annotation. I overlooked that for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Editor UI User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A separate tab for hints for env files has appeared in the settings.

4 participants