boards/xtensa: heltec_wifi_lora_32: Add userleds support#18831
Open
Shriyans406 wants to merge 1 commit into
Open
boards/xtensa: heltec_wifi_lora_32: Add userleds support#18831Shriyans406 wants to merge 1 commit into
Shriyans406 wants to merge 1 commit into
Conversation
github-actions
Bot
added
Size: S
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
from
69d120b to
c830627
Compare
github-actions
Bot
added
Size: M
linguini1
requested changes
May 2, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Please fill out the PR template according to the contribution guide, and also run ./tools/checkpatch.sh on your changes to make sure it meets the coding style (that is why CI is failing)
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
2 times, most recently
from
7a04e7e to
2fbefa9
Compare
jerpelea
previously approved these changes
May 4, 2026
eren-terzioglu
previously approved these changes
May 4, 2026
Contributor
|
@Shriyans406 please fix these issues in your file: |
Contributor
Do you have like a photo of the LED working on your board? Or how did you verify registration? |
linguini1
reviewed
May 6, 2026
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
from
2fbefa9 to
e6668ca
Compare
jerpelea
previously approved these changes
May 7, 2026
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
3 times, most recently
from
83a8199 to
07139eb
Compare
Contributor
|
@Shriyans406 still contain ci error: |
Author
|
Sorry for the late response as I was having my examinations, I have made
the required changes.
Regards
…On Tue, May 26, 2026 at 7:38 AM Xiang Xiao ***@***.***> wrote:
*xiaoxiang781216* left a comment (apache/nuttx#18831)
<#18831 (comment)>
@Shriyans406 <https://github.com/Shriyans406> still contain ci error:
../nuttx/tools/checkpatch.sh -c -u -m -g b82b5d0..HEAD
Used config files:
1: .codespellrc
Error: /home/runner/work/nuttx/nuttx/nuttx/boards/xtensa/esp32/heltec_wifi_lora32/src/heltec_wifi_lora32.h:49:1: error: Too many blank lines
Some checks failed. For contributing guidelines, see:
https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
Error: Process completed with exit code 1.
—
Reply to this email directly, view it on GitHub
<#18831?email_source=notifications&email_token=BMTFX7WDFUPVXACOGARZWD344T4BXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJTHEYTAMBYGU3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4539100856>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMTFX7UKFLCUTEKSWLOUQVL44T4BXAVCNFSM6AAAAACYOBZOHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMZZGEYDAOBVGY>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
Did you actually test this on the board? Also please fix the PR title that is truncated. |
Shriyans406
changed the title
Author
|
Thank you for the review
1. Yes, I have tested this and verified that the LED functions correctly.
2. I have updated the PR title to fix the truncation and accurately reflect
the changes.
3. I also fixed the trailing blank lines checkpatch error, and the CI
should pass now.
Please let me know if there is anything else needed
Regards
…On Wed, Jun 3, 2026 at 12:49 AM Matteo Golin ***@***.***> wrote:
*linguini1* left a comment (apache/nuttx#18831)
<#18831 (comment)>
Did you actually test this on the board? Also please fix the PR title that
is truncated.
—
Reply to this email directly, view it on GitHub
<#18831?email_source=notifications&email_token=BMTFX7WSEBVOQSBULHTQT2T454SCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRQGYZDGMBTGMZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4606230332>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMTFX7QZ5U4KJW3UI36HEWL454SCRAVCNFSM6AAAAACYOBZOHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMMBWGIZTAMZTGI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BMTFX7SIWEV6KB44OFXT3XL454SCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRQGYZDGMBTGMZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BMTFX7XAVRBLSL53Z3I26YT454SCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRQGYZDGMBTGMZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
@Shriyans406 please fix these issues: |
Contributor
|
@Shriyans406 I think many of these issues are happening because you use merge instead of git rebase. |
This commit adds the User LED driver support for the Heltec WiFi LoRa 32 board. It implements the lower-half driver, maps the onboard white LED to GPIO 25, and adds the necessary build system and initialization logic. Signed-off-by: Shriyans S Sahoo <shriyans.s.sahoo@gmail.com>
Shriyans406
force-pushed
the
boards/esp32/heltec_leds
branch
from
6ff1757 to
7ce951f
Compare
xiaoxiang781216
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for the onboard User LED on the Heltec WiFi LoRa 32 board. This board-specific implementation utilizes the standard NuttX User LED framework (
/dev/userleds), mapping the white LED to GPIO 25. Cleaned up a conflicting legacyGPIO_LED1definition.Impact
Enables the
/dev/userledscharacter device on theheltec_wifi_lora32board. No impact on other boards or existing architectures.Testing
Tested by building the
heltec_wifi_lora32configuration in a Linux environment. Verified the driver registration inesp32_bringup.cand validated the coding style usingcheckpatch.sh.