RANGER-5498: Use provided saltSize parameter at all places in generat…#860
Merged
vikaskr22 merged 1 commit intoapache:masterfrom Feb 26, 2026
Merged
RANGER-5498: Use provided saltSize parameter at all places in generat…#860vikaskr22 merged 1 commit intoapache:masterfrom
vikaskr22 merged 1 commit intoapache:masterfrom
Conversation
vikaskr22
requested review from
dhavalshah9131,
dineshkumar-yadav and
spolavarpau1
spolavarpau1
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RangerMasterKey has generateSalt(int saltSize) method. In case of FIPS, if user provided saltSize is small, then code calculates the compliant salt size and then generates the salt. The parameter of the method contains the new calculated size and this method is expected to use this size only.
While copying the generated salt to target byte[], it was using the static member instance with the same variable name. Right now it is working because both has same value but it may create problem if static member and new calculated value starts containing different value. So to avoid such issues and as a good coding practice, code is updated to use the provided parameter only.
How was this patch tested?