feat(collection): added alias management - #159
Open
y-luis-rojo wants to merge 8 commits into
Open
Conversation
adityamparikh
left a comment
adityamparikh
left a comment
Contributor
There was a problem hiding this comment.
Thanks @y-luis-rojo for the contribution. Seems like a useful capability to add.
Added inline comments as well as overall comments to address:
- Looks like the happy path in unit tests need actual assertions.
- Please add an AliasServiceIntegrationTest that uses Testcontainers to test adding, updating, removing aliases on a new or existing collection.
- Please update the docs with this new tool.
create-alias destructive and idempotent. Added tests. Updated documentation.
Author
Thanks for the comments. I think all are now addressed. |
Contributor
|
An end to end integration tests |
Author
Sorry, missed to add it. Done. |
adityamparikh
suggested changes
Jul 9, 2026
- Derive success from response.getStatus() instead of hardcoding true - Add @jsonformat to AliasResult timestamp for ISO 8601 consistency - Use separate TEST_COLLECTION_2 in integration test update scenario
y-luis-rojo
force-pushed
the
feature/alias-management
branch
from
July 10, 2026 12:56
4068819 to
72df1c5
Compare
adityamparikh
approved these changes
Jul 10, 2026
Contributor
|
@epugh Looks good to me. Can you please merge? |
Contributor
thanks for the review! Still on vacation, but hoping to get some coding time this week. |
Contributor
|
@y-luis-rojo looks like some lint checks failed... |
The Build job runs './gradlew classes testClasses spotlessCheck' as a fail-fast gate, and spotlessJavaCheck rejected the new alias files for indentation (spaces where the project's format expects tabs). Because Unit Tests and Integration Tests are gated behind Build, this single formatting miss blocked the entire pipeline. No functional change - output of './gradlew spotlessApply'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
createAlias_multipleAliasesCanExist (@order(5)) asserted that TEST_ALIAS still pointed at TEST_COLLECTION, but createAlias_updatesExistingAlias (@order(4)) had already repointed it to TEST_COLLECTION_2 - and asserts that it did. The expectation therefore contradicted the preceding test and failed deterministically: AliasServiceIntegrationTest > createAlias_multipleAliasesCanExist() FAILED java.lang.AssertionError at AliasServiceIntegrationTest.java:119 AliasService itself is correct; only the test expectation was stale. Rather than just correcting the expected value, this makes the test assert solely on aliases it creates itself, so it no longer depends on what an earlier test left TEST_ALIAS pointing at. TEST_ALIAS_2 is still left in place for the deletion tests that follow; TEST_ALIAS_3 is this test's own fixture and is cleaned up in the test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
fix(alias): resolve CI failures on apache#159 (spotless + stale test expectation)
adityamparikh
approved these changes
Jul 22, 2026
Contributor
|
I approved. @epugh Could we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(collection): add alias management tools (list, create, delete)