SOLR-18403: fix snapshot-export to actually use the named snapshot - #4807
Open
serhiy-bzhezytskyy wants to merge 2 commits into
Open
SOLR-18403: fix snapshot-export to actually use the named snapshot#4807serhiy-bzhezytskyy wants to merge 2 commits into
serhiy-bzhezytskyy wants to merge 2 commits into
Conversation
SnapshotExportTool built a Backup request with setCommitName(snapshotName) but never called setIncremental(false) -- commitName is only read by the non-incremental backup path, so it was silently ignored and the export backed up the live index instead. Verified with a real MiniSolrCloudCluster test: 5 docs snapshotted, 5 more indexed, export+restore returned 10 docs before this fix, 5 after.
Contributor
Author
|
Cross-referencing: #4808 (SOLR-18358) removes the same |
Contributor
|
thanks for this... Yeah, lets see what folks say about jsut removing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18403
SnapshotExportToolbuilt itsBackuprequest withsetCommitName(snapshotName)but never calledsetIncremental(false).commitNameis only read by the non-incremental backup path, so it was silently ignored and the export backed up the live index instead of the named snapshot -- no error, no warning.Verified with a real
MiniSolrCloudClustertest: indexed 5 docs, snapshotted, indexed 5 more (live index now 10), exported, restored -- got 10 docs before this fix, 5 after. Confirmed the test actually catches the regression (reverted the one-line fix locally, test failed as expected, restored it).This predates incremental backups entirely -- the
commitName-based export worked correctly before SOLR-13608 introducedincrementaldefaulting totruein 2021. That interaction was never revisited, and SOLR-17180 (2024) carried the bug forward unchanged when portingsnapshotscli.shintobin/solr snapshot-export.AI-assisted (Claude Sonnet 5)