[SPARK-54824] Add support for multiGet and deleteRange for Rocksdb State Store #53583
+186
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val valuesList = db.multiGetAsList(readOptions, keysList) | ||
|
|
||
| // Convert to Array[Array[Byte]] in one line | ||
| valuesList.toArray(new Array[Array[Byte]](valuesList.size())) |
Contributor
There was a problem hiding this comment.
This will invoke another copy ? can we leave it as java.util.List ?
| colFamilyName: String = StateStore.DEFAULT_COL_FAMILY_NAME): UnsafeRow | ||
|
|
||
| def multiGet(keys: Array[UnsafeRow], colFamilyName: String): Iterator[UnsafeRow] = { | ||
| keys.iterator.map(key => get(key, colFamilyName)) |
Contributor
There was a problem hiding this comment.
Why not just do the override in HDFSProvider for this ?
| tryWithProviderResource( | ||
| newStoreProvider( | ||
| keySchemaWithRangeScan, | ||
| RangeKeyScanStateEncoderSpec(keySchemaWithRangeScan, Seq(0)), |
Contributor
There was a problem hiding this comment.
Should we enforce in the code that deleteRange will only work for range scan encoder ?
| } | ||
| } | ||
|
|
||
| test("multiGet - batch retrieval of multiple keys") { |
Contributor
There was a problem hiding this comment.
Lets add the test for HDFS provider also in case we plan to support it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for multiGet and deleteRange for Rocksdb State Store
Why are the changes needed?
For some streaming operators, using multiGet and deleteRange can improve the read/write performance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT
Was this patch authored or co-authored using generative AI tooling?
No