Skip to content

[SPARK-54753][SQL] Fix memory leak of ArtifactManager (to branch 4.1) #53592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scottme wants to merge 1 commit into from
+7 −2
Closed

[SPARK-54753][SQL] Fix memory leak of ArtifactManager (to branch 4.1) #53592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/artifact/ArtifactManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,7 @@ class ArtifactManager(session: SparkSession) extends AutoCloseable with Logging
artifactPath)
// Ensure that no reference to `this` is captured/help by the cleanup lambda
private def getCleanable: Cleaner.Cleanable = cleaner.register(
this,
() => ArtifactManager.cleanUpGlobalResources(cleanUpStateForGlobalResources)
this, new StateCleanupRunner(cleanUpStateForGlobalResources)
)
private var cleanable = getCleanable

Expand Down Expand Up @@ -529,6 +528,12 @@ object ArtifactManager extends Logging {
val JAR, FILE, ARCHIVE = Value
}

private class StateCleanupRunner(cleanupState: ArtifactStateForCleanup) extends Runnable {
override def run(): Unit = {
ArtifactManager.cleanUpGlobalResources(cleanupState)
}
}

// Shared cleaner instance
private val cleaner: Cleaner = Cleaner.create()

Expand Down