[SPARK-54835][SQL] Avoid unnecessary temp QueryExecution for nested command execution #53596
+68
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Dec 24, 2025
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
commented
Dec 24, 2025
| } | ||
| } | ||
|
|
||
| test("CTAS/RTAS should trigger two query executions") { |
Contributor
Author
There was a problem hiding this comment.
This test can pass before this PR, I'm adding it just to make sure this refactor doesn't break it and still reports two executions.
Contributor
Author
|
cc @pan3793 |
pan3793
reviewed
Dec 24, 2025
...e/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
Show resolved
Hide resolved
cloud-fan
commented
Dec 25, 2025
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala
Outdated
Show resolved
Hide resolved
…rceV2DataFrameSuite.scala
pan3793
approved these changes
Dec 25, 2025
cloud-fan
commented
Dec 25, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
Outdated
Show resolved
Hide resolved
cloud-fan
commented
Dec 25, 2025
...e/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a small refactor. In DS v2 CRAS/RTAS command, we run a nested
AppendData/OverwriteByExpressioncommand by creating aQueryExecution. ThisQueryExecutionwill create another tempQueryExecutionto eagerly execute commands. This PR avoids the unnecessary tempQueryExecutionby usingCommandExecutionMode.SKIPto createQueryExecution.Why are the changes needed?
Remove useless temp
QueryExecutionobjects.Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
cursor 2.2.43