[SPARK-54840][SQL] OrcList Pre-allocation #53605
Open
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR optimizes ORC serialization performance by pre-allocating
OrcListwith the exact array size instead of relying on dynamic resizing.Key changes:
OrcListwithnumElementsfrom the input arraynumElementsvalue to avoid redundant calls in the loop conditionWhy are the changes needed?
Problem:
When serializing arrays to ORC format, the current implementation creates an empty
OrcList(which extendsArrayList) and grows it dynamically. For large arrays, this triggers multiple resize operations, each requiring:Performance Impact:
For an array with 65,536 elements, the default ArrayList growth pattern (1.5x capacity increase) causes ~16 resize operations, copying approximately 1 million elements in total.
Solution:
By pre-allocating the
OrcListwith the known size, we eliminate all resize operations and associated element copying, resulting in:Does this PR introduce any user-facing change?
No. This is a performance optimization with no functional changes. The output remains identical.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
GitHub Copilot w/ Claude Sonnet 4.5