[SPARK-53520][SQL] Handle TimeType in javaBoxedType()#55948
Open
yadavay-amzn wants to merge 1 commit into
Open
[SPARK-53520][SQL] Handle TimeType in javaBoxedType()#55948yadavay-amzn wants to merge 1 commit into
yadavay-amzn wants to merge 1 commit into
Conversation
Adds TimeType handling to javaBoxedType() to return the appropriate Java boxed type for Time values. Closes #SPARK-53520
yadavay-amzn
force-pushed
the
fix/SPARK-53520-timetype-javaboxed
branch
from
c432269 to
6804131
Compare
Contributor
Author
|
@MaxGekk Could you please take a look at this one-liner when you get a chance? |
MaxGekk
reviewed
May 20, 2026
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
TimeType is internally stored as microseconds since midnight.
It is stored as nanoseconds, see #51156
javaBoxedType() does not handle TimeType, causing a MatchError when encoding Time values.
How do you get it if there is the default case?
...
case _ => typeBoxedJavaMapping.getOrElse(dt, classOf[java.lang.Object])Is this user-visible bug? Can you reproduce it via public API? For example, via an end-to-end round-trip of Row(LocalTime) through the real encoder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds
TimeTypehandling tojavaBoxedType()inEncoderUtils.scala, returningclassOf[java.lang.Long]since TimeType is internally stored as microseconds since midnight.Why are the changes needed?
javaBoxedType()does not handleTimeType, causing aMatchErrorwhen encoding Time values. Part of Spark 4.3 release work (SPARK-56754).Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added
EncoderUtilsSuitewith a test verifyingjavaBoxedType(TimeType)returnsclassOf[java.lang.Long]. Test fails without the fix (MatchError), passes with it.Was this patch authored or co-authored using generative AI tooling?
No