Skip to content

[SPARK-54476][PYTHON][TEST] Add coverage test for try_mod #55964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

[SPARK-54476][PYTHON][TEST] Add coverage test for try_mod #55964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions python/pyspark/sql/tests/test_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,14 @@ def test_try_make_interval(self):
actual = df.select(F.isnull(F.try_make_interval("num")))
assertDataFrameEqual([Row(True)], actual)

def test_try_mod_function(self):
df = self.spark.createDataFrame([(6000, 15), (3, 2), (1234, 0)], ["a", "b"])
Copy link
Copy Markdown
Contributor

@zhengruifeng zhengruifeng May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems already been tested as a doc-test

https://github.com/apache/spark/blob/master/python/pyspark/sql/functions/builtin.py#L762-L774

Copy link
Copy Markdown
Contributor Author

@fallintoplace fallintoplace May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @zhengruifeng, thanks. I missed that the main try_mod behavior is already covered by the doctest. The only additional coverage here is the Column + literal path, which is probably too small to justify a separate test. I will close this PR unless you think explicit coverage in test_functions.py is still useful for SPARK-54476.

actual = df.select(F.try_mod("a", "b").alias("r"))
assertDataFrameEqual([Row(r=0), Row(r=1), Row(r=None)], actual)

actual = df.select(F.try_mod(F.col("a"), F.lit(2)).alias("r"))
assertDataFrameEqual([Row(r=0), Row(r=1), Row(r=0)], actual)

def test_octet_length_function(self):
# SPARK-36751: add octet length api for python
df = self.spark.createDataFrame([("cat",), ("\U0001f408",)], ["cat"])
Expand Down