Skip to content

Comments

Make sure we always throw Thrift::ProtocolException(INVALID_DATA) in Ruby#3302

Merged
Jens-G merged 1 commit intoapache:masterfrom
kpumuk:rb-validation
Feb 21, 2026
Merged

Make sure we always throw Thrift::ProtocolException(INVALID_DATA) in Ruby#3302
Jens-G merged 1 commit intoapache:masterfrom
kpumuk:rb-validation

Conversation

@kpumuk
Copy link
Contributor

@kpumuk kpumuk commented Feb 10, 2026

Currently, Ruby is the only client that throws ProtocolException with UNKNOWN type when validation fails. Additionally, there is an edge case for Union type where validation produces StandardError.

With this change we make sure it is always Thrift::ProtocolException with INVALID_DATA code.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G
Copy link
Member

Jens-G commented Feb 19, 2026

Not sure what that msvc error is about, could you just kick'em again by rebasing?

@Jens-G Jens-G merged commit 32776c0 into apache:master Feb 21, 2026
114 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants