feat: Support direct construction of tvm_ffi.Function from callables

[junrushao]

blocked by cuteDSL usage of this private API

Add __init__ to the Cython Function class so users can write:

fadd = tvm_ffi.Function(add)

instead of going through tvm_ffi.convert_to_tvm_func. The constructor:

• Validates that the argument is callable
• Copies the handle (with incref) if the input is already a Function
• Otherwise converts via _convert_to_ffi_func_handle

Also adds the corresponding type stub in core.pyi and a test in test_function.py.

Re-lands the original change reverted in #406.

[gemini-code-assist]

Summary of Changes

Hello @junrushao, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the tvm_ffi.Function class by allowing direct construction from Python callables. This change streamlines the process of wrapping Python functions for use within the TVM FFI system, making the API more intuitive and reducing the need for explicit conversion utilities. It also includes necessary type hinting and a dedicated test to ensure correctness and maintainability.

Highlights

• Direct Function Construction: Enabled direct initialization of tvm_ffi.Function objects from Python callables, simplifying API usage by allowing tvm_ffi.Function(my_python_func).
• Robust Constructor Logic: Implemented the __init__ method with validation for callable arguments, proper handling of existing tvm_ffi.Function instances (with reference counting), and conversion for other callables via _convert_to_ffi_func_handle.
• Type Stub and Test Coverage: Added a type stub for the new __init__ method in core.pyi and a new test case in test_function.py to verify the functionality of direct callable wrapping.
• Re-landed Feature: This change re-introduces functionality that was previously reverted in a prior pull request (Revert "feat: Add tvm_ffi.Function.__init__" #406).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/tvm_ffi/core.pyi
  • Added __init__ method signature to the Function class.
• python/tvm_ffi/cython/function.pxi
  • Implemented the __init__ method for the Function class to accept a Python callable.
  • Added logic to validate if the input is callable.
  • Included logic to handle tvm_ffi.Function instances by incrementing their reference count.
  • Integrated _convert_to_ffi_func_handle for other callable types.
• tests/python/test_function.py
  • Added test_pyfunc_init to verify the direct construction of tvm_ffi.Function from a Python function.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a convenient __init__ method for the tvm_ffi.Function class, allowing direct instantiation from Python callables. The changes include the implementation in Cython, corresponding type stubs, and a new test case. My review focuses on improving the implementation's clarity and expanding test coverage for the new feature. I've suggested a small refactoring in the constructor logic for better readability and proposed additions to the test suite to cover more scenarios, such as creating a Function from an existing one and handling non-callable inputs.

[tqchen]

we need to hold this after a few cutedsl releases

[tqchen]

we need to hold the change for a few cutedsl releases before cutedsl get updated