[Relax][VM] Improve diagnostics for unlowered Relax operators - #19899
Draft
yinli-systems wants to merge 3 commits into
Draft
[Relax][VM] Improve diagnostics for unlowered Relax operators#19899yinli-systems wants to merge 3 commits into
yinli-systems wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the error messages in CodeGenVM and CodeGenVMTIR when encountering an unlowered Relax operator, providing clearer guidance on how to resolve the issue and printing the offending call. A unit test has also been added to verify this error behavior. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This improves the diagnostics emitted when VM codegen sees a normal Relax operator that was not lowered before codegen.
CodeGenVM) and compiled (CodeGenVMTIR) paths.relax.nn.conv2d_transposelayout so the diagnostic exposes the layout attributes.Why
Issue #19694 reports that unsupported
conv{1,2,3}d_transposeattributes can pass through legalization and later fail with an opaque VM codegen error that only names the operator. Recent upstream work added dilation support, while layout/out-layout passthrough remains useful for external codegen flows. This keeps legalization behavior unchanged but makes an eventual VM failure actionable by showing the exact unlowered call and how to address it.Helps #19694.
Validation
main(87 upstream commits at validation time) without changing the three-file PR scope.USE_LLVM=OFF):tvm_runtimeandtvm_compilercompleted successfully.tvm-ffisubmodule as a non-editable wheel, per repository guidance.pytest tests/python/relax/test_vm_build.py -k test_vm_compile_unlowered_operator_error -vv: 2 passed (bytecodeandcompiled). The diagnostic is raised before low-level LLVM code generation, so the test is valid in this build configuration.git diff upstream/main --checkpassed.The previous branch CI was also green on Windows, macOS, and lint before the latest-main merge.
AI assistance
AI tooling assisted with validation and branch maintenance. I reviewed the final diagnostic and test behavior and ran the source build, targeted tests, and pre-commit checks listed above.