[FIX][TIRx] Constant-fold copy slice extents - #20067
Merged
spectrometerHBH merged 1 commit intoJul 29, 2026
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Copy regions can retain constant-valued expressions after variable substitution. Simplify swizzled-region extents before converting them to Python integers, while preserving rejection of genuinely symbolic extents. Add a hardware-independent regression test for an unfolded constant slice extent.
jinhongyii
force-pushed
the
upstream/tirx-copy-slice-extent
branch
from
July 29, 2026 05:03
94fee76 to
8076cb5
Compare
spectrometerHBH
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
Copy regions can retain constant-valued expressions after variable substitution. Converting those expressions directly to Python integers rejects valid slices even though their extents are statically known.
Changes
Testing
python -m pytest tests/python/tirx/test_layout.py