[FIX][TIRx] Remap buffers consistently in ConvertSSA - #20069
Merged
spectrometerHBH merged 1 commit intoJul 29, 2026
Merged
Conversation
ConvertSSA caches remapped buffers while an SSA-renamed variable is in scope. The cleanup previously popped a cached buffer only when the renamed variable was its data pointer, leaving remaps through elem_offset, shape, strides, or tile layout fields alive after scope exit. Recognize dependencies in every field rewritten by GetRemappedBuffer, and add a regression with reused sibling loop variables and a variable-dependent elem_offset.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
spectrometerHBH
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
ConvertSSA caches remapped buffers while an SSA-renamed variable is in scope. Cleanup previously removed a cached buffer only when the renamed variable was its data pointer, so remaps through other buffer fields could survive after scope exit.
Changes
GetRemappedBuffer, including shape, strides, element offset, and tile layout fields.Testing
python -m pytest tests/python/tirx-transform/test_tir_transform_convert_ssa.py