[FIX][TIRx] Use cluster arrivals for remote mbarrier views - #20074
Open
jinhongyii wants to merge 1 commit into
Open
[FIX][TIRx] Use cluster arrivals for remote mbarrier views#20074jinhongyii wants to merge 1 commit into
jinhongyii wants to merge 1 commit into
Conversation
Keep the owner-local barrier pointer and target CTA rank on remote views so plain and expect-tx arrivals use the shared::cluster helpers. Type the mapped pointer as shared memory and reject local-only or ambiguous operations with diagnostics.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
MBarrier.remote_view(rank)represents an mbarrier owned by another CTA in the same cluster. The existing view kept only a buffer whose pointer had been mapped to the remote CTA with PTXmapa. Callingremote_bar.arrive(...)then followed the inherited local-arrive path and emitted the localmbarrier.arrive.shared.b64form against that mapped remote address.A remote arrival must instead use the
shared::clusterinstruction form. TIRx models that form with the owner-local barrier pointer plus the destination CTA rank and predicate. Using the local instruction with a remote address is not equivalent and is reported by synccheck as a local arrival on a remote mbarrier address.Changes
MBarrierremote arrivals through the cluster helper using the local barrier pointer and stored CTA rank.TMABar, includingmbarrier.arrive.expect_tx.PointerType(uint64, shared)mapped buffer on the view soptr_toremains available to operations that explicitly consume a remote shared-memory pointer.cta_idto a view that already fixes its target,Testing
mapabinding and remote buffer in TIRx IR.mbarrier.arrive.shared::cluster.b64forms.mbarrier.arrive.expect_tx.shared::cluster.b64.cta_idarguments.Focused result: 3 tests passed.