ZOOKEEPER-4982 Automatic HostProvider selection based on connection string format#2321
Closed
li4wang wants to merge 2 commits intoapache:masterfrom
Closed
ZOOKEEPER-4982 Automatic HostProvider selection based on connection string format#2321li4wang wants to merge 2 commits intoapache:masterfrom
li4wang wants to merge 2 commits intoapache:masterfrom
Conversation
li4wang
force-pushed
the
ZOOKEEPER-4982
branch
2 times, most recently
from
7f4fa51 to
f854d9e
Compare
…ynamic server discovery Author: Li Wang <liwang@apple.com>
li4wang
force-pushed
the
ZOOKEEPER-4982
branch
3 times, most recently
from
6888281 to
dc8e0f5
Compare
…string format Author: Li Wang <liwang@apple.com>
li4wang
force-pushed
the
ZOOKEEPER-4982
branch
from
dc8e0f5 to
32ae4ce
Compare
anmolnar
requested changes
Dec 18, 2025
Contributor
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
Please create one single pull request with all the changes included. The size of the change doesn't justify splitting into multiple, but it would make backporting harder.
zookeeper-server/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
Show resolved
Hide resolved
Contributor
Author
Used #2320 as the single pull request for all the changes. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements automatic HostProvider selection based on connection string format, enabling ZooKeeper clients to automatically choose the appropriate HostProvider (e.g. DnsSrvHostProvder and StaticHostProvider) implementation without manual configuration.
The summary of the changes are :
The changes are in the 2nd commit:
6888281
The first commit d92a622
is for the dependent JIRA https://issues.apache.org/jira/browse/ZOOKEEPER-4956. This PR will be updated once #2320 is merged.