ZOOKEEPER-4892: Keep self vote in sync in FastLeaderElection TLA receiveVotes#2355
Open
arup-chauhan wants to merge 1 commit intoapache:masterfrom
Open
ZOOKEEPER-4892: Keep self vote in sync in FastLeaderElection TLA receiveVotes#2355arup-chauhan wants to merge 1 commit intoapache:masterfrom
arup-chauhan wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Arup Chauhan <arupchauhan.connect@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first incremental change for ZOOKEEPER-4892.
Scope is intentionally limited to FastLeaderElection TLA vote-state synchronization.
When a server updates its proposal in LOOKING flow, its self entry in
receiveVotes[i][i]must reflect the same current vote. I have not changed the Java runtime code and change is limited to TLA model consistency for self-vote tracking.This is PR-1 of a planned 2-PR sequence for ZOOKEEPER-4892. PR-2 will cover quorum vote-set/counting alignment (
VoteSet/HasQuorums).Changes
RvPut(...)inzookeeper-specifications/system-spec/zk-3.7/FastLeaderElection.tla:receiveVotes[i][i]withcurrentVote'[i]RvClearAndPut(...):v = i) tocurrentVote'[i]Validation
mvn -q -DskipTests installmvn -q -pl zookeeper-server -DskipTests compileCHOOSEatNullPointin base file, which blocks full BFS model checking.NullPointrun was used to complete TLC simulation sanity.