Repository navigation
No Way to Set "isRequired" to True in Filter Params #595
Description
Activity
After some digging, I managed to figure out that this
isRequiredproperty actually comes from the filter traits.Example for the
SearchFilter, using theSearchFilterTrait, it is defined here:Unfortunately, for all currently implemented filter traits, this property is always set to
false.
So I guess this is not implemented yet.However, if you implement your own filter + trait, then it works fine!
// SearchFilterTrait.php namespace App\Filter; // use ... trait SearchFilterTrait { // ... public function getDescription(string $resourceClass): array { // ... foreach ($filterParameterNames as $filterParameterName) { $description[$filterParameterName] = [ 'property' => $propertyName, 'type' => $typeOfField, 'required' => true, 'strategy' => $strategy, 'is_collection' => str_ends_with((string) $filterParameterName, '[]'), ]; } // ... } // ... }
// SearchFilter.php namespace App\Filter; use App\Filter\SearchFilterTrait; // other imports... final class SearchFilter extends AbstractFilter implements SearchFilterInterface { use SearchFilterTrait; // ... }
// Greeting.php namespace App\Entity; use App\Filter\SearchFilter; // other imports... #[ApiResource(mercure: true)] #[ORM\Entity] #[ApiFilter(OrderFilter::class, properties: ['name'], arguments: ['orderParameterName' => 'order'])] class Greeting { /** * The entity ID */ #[ORM\Id] #[ORM\Column(type: 'integer')] #[ORM\GeneratedValue(strategy: 'SEQUENCE')] #[ORM\SequenceGenerator(sequenceName: 'greeting_seq', initialValue: 1, allocationSize: 100)] private ?int $id = null; /** * A nice person */ #[ORM\Column] #[Assert\NotBlank] #[ApiFilter(SearchFilter::class, strategy: 'partial')] public string $name = ''; }
Thinking about it, I'm starting to question the rationale of assuming that having a required filter necessarily means it should be always displayed (
alwaysOn).FTR: this rationale is implemented here:
admin/src/list/FilterGuesser.tsx
Line 48 in 2027186
To me, these are two different things.
Wanting a filter to be always displayed or not is a UI concern, not a schema one. So in such a case, you would need to manually add the filter to your
<Admin>, and set thealwaysOnprop there.
In the end, to me, this is not necessarily a feature that would need to be implemented, but rather something to document.Hello @slax57 , thanks for looking into this and for the suggesting about the custom trait!
I think we have two issues:
-
On the API Platform side, that "required" boolean should be configurable (if it's going to exist)... that seems indisputable to me.
-
On the API Platform Admin side, I agree that how to interpret that value is more disputable.
Personally, I encountered this issue because I was specifically looking for a quick / central way to control which filter inputs are visible by default and which are hidden behind the Add Filter menu.
So for me, it would be convenient if the "required" boolean were configurable, and I'm satisfied with the API Platform Admin interpretation of that value.
Reacted by Jean-Baptiste Kaiser-
API Platform version(s) affected: 4.0.3
Description
If you introspect the API Platform data and look at the Filter Params, there is a property "isRequired". It is always false no matter what I do with the API Platform configuration.
The FilterGuesser seems to want to evaluate that property to determine whether a filter should be "alwaysOn"... but I can't find any way tot set it.
How to reproduce
Create a Doctrine Entity with a SearchFilter configured.
In RA, introspect the API with something like this:
Notice in the console the Filter Params have an isRequired property set to false.
There are no docs about how to set it to true and various things I've tried with ApiProperty aren't working.