fix(laravel): expose ReDoc/Scalar in docs footer#7942
Open
abderrahimghazali wants to merge 1 commit intoapi-platform:4.3from
Open
fix(laravel): expose ReDoc/Scalar in docs footer#7942abderrahimghazali wants to merge 1 commit intoapi-platform:4.3from
abderrahimghazali wants to merge 1 commit intoapi-platform:4.3from
Conversation
abderrahimghazali
force-pushed
the
fix/laravel-redoc-discoverability
branch
from
b2a14a6 to
ebb78c2
Compare
Member
|
Thanks for the patch! Instead of this huge button on symfony we just have a few links on the bottom: Could we have the same? Also feel free to target 4.3, as we have this functionality already in Symfony we consider its a bug fix thanks! |
abderrahimghazali
force-pushed
the
fix/laravel-redoc-discoverability
branch
from
ebb78c2 to
b74218a
Compare
abderrahimghazali
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the Symfony footer (
SwaggerUi/index.html.twig#L84-L98) in the Laravelswagger-ui.blade.php: available formats plus an "Other API docs" switcher to ReDoc/Scalar/GraphiQL when each is enabled. Hidden under Scalar, which provides its own UI.Also fixes
originalRoute/originalRouteParamsinSwaggerUiProcessor(the previous lookup relied on the Symfony-only_routeattribute and was always null on Laravel) and passes the missingformatsargument when wiring the processor.