ci: remove dead Coveralls integration - #8456
Merged
Merged
Conversation
The Coveralls GitHub App is not installed on the org, so its callback never posted a check or status: zero Coveralls check runs across sampled commits, only codecov/patch and codecov/project. The upload also passed GITHUB_TOKEN to a third party for no benefit. Codecov covers coverage reporting with its own token and App. Also drops PHP_COVERALLS_VERSION, added in api-platform#8442, now unreferenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Coveralls GitHub App is not installed on the organization, so Coveralls' callback to GitHub never posted a check or a status. Sampling recent commits shows zero Coveralls check runs — only
codecov/patchandcodecov/project. The integration uploaded coverage that nothing surfaced, and passedGITHUB_TOKENto a third party to do it.Codecov already covers coverage reporting, with its own
CODECOV_TOKENand its own GitHub App. No Codecov step is touched here.Removed:
Upload coverage results to Coverallsstepsphp-coveralls/php-coverallsglobal composer installs that fed themPHP_COVERALLS_VERSIONenv var added in ci: pin build tooling to exact versions #8442, now unreferencedNothing else in the repo referenced Coveralls (no
.coveralls.yml, no README badge, no composer dev dependency).The shared coverage machinery is untouched:
matrix.coveragestill drives clover generation and still gates the Codecov steps, and all threecoverage: truematrix includes remain in use.Related to #8440, which restricted default token permissions to read-only.