Repository navigation
fix(laravel): accept null on an optional belongsTo - #8666
Open
devtechedge wants to merge 1 commit into
Open
devtechedge wants to merge 1 commit into
devtechedge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the report.
An optional BelongsTo whose foreign key is nullable should accept an explicit null, the same way Doctrine already does.
EloquentPropertyMetadataFactory wraps a nullable plain column with Type::nullable(), but a relation always became Type::object() and never looked at the foreign key.
I mark that relation nullable when the foreign key column is nullable, using the column name the relation already reports.
PersistProcessor skipped a null relation because isset() is false for null, so the null stayed as a raw attribute and the insert looked for a column named after the relation.
A present null on BelongsTo or MorphTo now calls dissociate() and unsets that attribute before save.
Omitting the key still leaves the stored relation alone.
I ran the filtered Issue8664Test on PHP 8.4, and POST and PATCH with the relation set to null no longer 500, with the foreign key null afterward.
Fixes #8664