Skip to content

fix: pin myuser UID/GID to 990 to prevent drift #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janbuchar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: pin myuser UID/GID to 990 to prevent drift #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node-phantomjs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get purge --auto-remove -y wget \
&& rm -rf /src/*.deb

# Run everything after as non-privileged user to avoid warnings
RUN groupadd -r myuser && useradd -r -g myuser -G audio,video myuser \
RUN groupadd -r -g 990 myuser && useradd -r -u 990 -g myuser -G audio,video myuser \
&& mkdir -p /home/myuser/Downloads \
&& chown -R myuser:myuser /home/myuser
USER myuser
Expand Down
2 changes: 1 addition & 1 deletion node-playwright-chrome/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Use bookworm to be consistent across node versions.
FROM --platform=linux/amd64 node:${NODE_VERSION}-bookworm-slim

LABEL maintainer="support@apify.com" description="Base image for Apify Actors using Chrome"

Check warning on line 5 in node-playwright-chrome/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-chrome node: 24, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 5 in node-playwright-chrome/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-chrome node: 24, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright-chrome/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-chrome node: 20, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright-chrome/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-chrome node: 20, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 5 in node-playwright-chrome/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-chrome node: 22, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright-chrome/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-chrome node: 22, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/
ENV DEBIAN_FRONTEND=noninteractive

# This image was inspired by https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-in-docker
Expand Down Expand Up @@ -32,7 +32,7 @@
--no-install-recommends \
\
# Add user so we don't need --no-sandbox.
&& groupadd -r myuser && useradd -r -g myuser -G audio,video myuser \
&& groupadd -r -g 990 myuser && useradd -r -u 990 -g myuser -G audio,video myuser \
&& mkdir -p /home/myuser/Downloads \
&& chown -R myuser:myuser /home/myuser \
\
Expand Down
2 changes: 1 addition & 1 deletion node-playwright-firefox/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Use bookworm to be consistent across node versions.
FROM --platform=linux/amd64 node:${NODE_VERSION}-bookworm-slim

LABEL maintainer="support@apify.com" description="Base image for Apify Actors using Firefox"

Check warning on line 5 in node-playwright-firefox/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-firefox node: 20, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 5 in node-playwright-firefox/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-firefox node: 22, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 5 in node-playwright-firefox/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-firefox node: 24, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/
ENV DEBIAN_FRONTEND=noninteractive

COPY ./register_intermediate_certs.sh ./register_intermediate_certs.sh
Expand All @@ -25,7 +25,7 @@
&& ./register_intermediate_certs.sh \
\
# Add user so we don't need --no-sandbox.
&& groupadd -r myuser && useradd -r -g myuser -G audio,video myuser \
&& groupadd -r -g 990 myuser && useradd -r -u 990 -g myuser -G audio,video myuser \
&& mkdir -p /home/myuser/Downloads \
&& chown -R myuser:myuser /home/myuser \
\
Expand Down
2 changes: 1 addition & 1 deletion node-playwright-webkit/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
ARG NODE_VERSION=20

LABEL maintainer="support@apify.com" description="Base image for Apify Actors using Webkit"
ENV DEBIAN_FRONTEND=noninteractive

Check warning on line 5 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 20, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 5 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 20, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 22, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 22, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 5 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 24, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 24, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-trixie-slim results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

# Install WebKit dependencies
RUN apt-get update \
Expand All @@ -21,7 +21,7 @@
&& npm install -g yarn \
\
# Add user so we don't need --no-sandbox.
&& groupadd -r myuser && useradd -r -g myuser -G audio,video myuser \
&& groupadd -r -g 990 myuser && useradd -r -u 990 -g myuser -G audio,video myuser \
&& mkdir -p /home/myuser/Downloads \
&& chown -R myuser:myuser /home/myuser \
# Globally disable the update-notifier.
Expand Down
2 changes: 1 addition & 1 deletion node-playwright/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FROM --platform=linux/amd64 mcr.microsoft.com/playwright:${PLAYWRIGHT_VERSION}jammy

ARG NODE_VERSION=20

Check warning on line 5 in node-playwright/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright node: 20, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright node: 22, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 5 in node-playwright/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright node: 24, apify: ^3.7.0, crawlee: ^3.16.0, pw: 1.59.1, cf: ^0.10.2, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/
LABEL maintainer="support@apify.com" description="Base image for Apify Actors using headless Chrome"
ENV DEBIAN_FRONTEND=noninteractive

Expand Down Expand Up @@ -34,7 +34,7 @@
&& apt install --fix-missing -yq ./google-chrome-stable_current_amd64.deb && rm ./google-chrome-stable_current_amd64.deb \
\
# Add user so we don't need --no-sandbox.
&& groupadd -r myuser && useradd -r -g myuser -G audio,video myuser \
&& groupadd -r -g 990 myuser && useradd -r -u 990 -g myuser -G audio,video myuser \
&& mkdir -p /home/myuser/Downloads \
&& chown -R myuser:myuser /home/myuser \
\
Expand Down
2 changes: 1 addition & 1 deletion node-puppeteer-chrome/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ RUN apt-get update \
&& apt install --fix-missing -yq ./google-chrome-stable_current_amd64.deb && rm ./google-chrome-stable_current_amd64.deb \
\
# Add user so we don't need --no-sandbox.
&& groupadd -r myuser && useradd -r -g myuser -G audio,video myuser \
&& groupadd -r -g 990 myuser && useradd -r -u 990 -g myuser -G audio,video myuser \
&& mkdir -p /home/myuser/Downloads \
&& chown -R myuser:myuser /home/myuser \
\
Expand Down
Loading