Skip to content

ci: Fix docs release failing on detached HEAD#1851

Merged
vdusek merged 1 commit intomasterfrom
fix/docs-release-detached-head
Apr 20, 2026
Merged

ci: Fix docs release failing on detached HEAD#1851
vdusek merged 1 commit intomasterfrom
fix/docs-release-detached-head

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented Apr 20, 2026

Summary

actions/checkout detaches HEAD when checking out a SHA, which blocks EndBug/add-and-commit from pushing the versioned docs commit. Pass new_branch so the action pushes to the default branch, and tighten the trigger contract so ref is only required for workflow_call (for workflow_dispatch the default branch is always used).

Mirrors apify/apify-client-python#741 and the equivalent fix in apify-sdk-python.

`actions/checkout` detaches HEAD when checking out a SHA, which blocks
`EndBug/add-and-commit` from pushing. Pass `new_branch` so the action
pushes to the default branch, and tighten the trigger contract so `ref`
is only required for `workflow_call`.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Apr 20, 2026
@vdusek vdusek self-assigned this Apr 20, 2026
@vdusek vdusek requested a review from Pijukatel April 20, 2026 10:40
@github-actions github-actions Bot added this to the 139th sprint - Tooling team milestone Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (306dc46) to head (7c515f5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
- Coverage   92.42%   92.38%   -0.05%     
==========================================
  Files         157      157              
  Lines       10921    10921              
==========================================
- Hits        10094    10089       -5     
- Misses        827      832       +5     
Flag Coverage Δ
unit 92.38% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit e01638c into master Apr 20, 2026
32 checks passed
@vdusek vdusek deleted the fix/docs-release-detached-head branch April 20, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants