Skip to content

fix(templates): Decouple the Camoufox Playwright version from other images - #2189

Merged
Pijukatel merged 1 commit into
masterfrom
claude/crawlee-python-pr-2183-yvfnl7
Aug 25, 2026
Merged

fix(templates): Decouple the Camoufox Playwright version from other images#2189
Pijukatel merged 1 commit into
masterfrom
claude/crawlee-python-pr-2183-yvfnl7

Conversation

@Pijukatel

Copy link
Copy Markdown
Collaborator

Description

Pin camoufox_playwright_version to make it independent of other Playwright versions used in non-Camoufox images

Issues

…dated one

Camoufox caps the Playwright version it supports, so the automated
Playwright version bump could move the shared pin past what the
Camoufox base image provides. Give Camoufox its own manually
maintained `camoufox_playwright_version` pin; the updater keeps
bumping the shared pin for the other Playwright images as before.

Closes #2175

Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NGgR6ymt6PhmeUvz69rZTj
@github-actions github-actions Bot added this to the 148th sprint - Tooling team milestone Aug 24, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 24, 2026
@Pijukatel Pijukatel changed the title fix(templates): decouple the Camoufox Playwright pin from the auto-up… fix(templates): Decouple the Camoufox Playwright version from other images Aug 24, 2026
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (2360392) to head (01e13aa).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2189      +/-   ##
==========================================
+ Coverage   93.68%   93.71%   +0.02%     
==========================================
  Files         181      181              
  Lines       12812    12825      +13     
==========================================
+ Hits        12003    12019      +16     
+ Misses        809      806       -3     
Flag Coverage Δ
unit 93.71% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pijukatel
Pijukatel requested a review from vdusek August 24, 2026 13:50

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel
Pijukatel merged commit da16f2c into master Aug 25, 2026
128 of 129 checks passed
@Pijukatel
Pijukatel deleted the claude/crawlee-python-pr-2183-yvfnl7 branch August 25, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playwright bump script ignores base image variants, breaking camoufox e2e

4 participants