Repository navigation
feat(autoscaling)!: Make AutoscaledPool.pause() async and wait for running tasks - #2365
Merged
Merged
Conversation
github-actions
Bot
added
the
t-tooling
vdusek
reviewed
Oct 30, 2026
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
vdusek
approved these changes
Nov 2, 2026
vdusek
changed the title
AutoscaledPool.pause() wait for the running tasksAutoscaledPool.pause() wait for running tasks
vdusek
changed the title
AutoscaledPool.pause() wait for running tasksAutoscaledPool.pause() async and wait for running tasks
vdusek
pushed a commit
that referenced
this pull request
Nov 5, 2026
…running tasks (#2365) ### Description `AutoscaledPool.pause()` is now a coroutine that returns once the pool's tasks in progress finish, like `pause()` in Crawlee JS. With the new `timeout` option, it raises `TimeoutError` if they take longer, and the pool stays paused. Nothing in Crawlee calls it yet. The crawler's `pause()` and `resume()` and pausing on migration need the per-run state from #2301. The upgrade guide covers the change. Where Crawlee JS doesn't keep the contract its `pause()` documents, this PR keeps it. A repeated `pause()` also waits for the tasks in progress. A `pause()` that comes while the pool awaits `is_task_ready_function` or `is_finished_function` doesn't let a new task start or `run()` return. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AutoscaledPool.pause()is now a coroutine that returns once the pool's tasks in progress finish, likepause()in Crawlee JS. With the newtimeoutoption, it raisesTimeoutErrorif they take longer, and the pool stays paused. Nothing in Crawlee calls it yet. The crawler'spause()andresume()and pausing on migration need the per-run state from #2301. The upgrade guide covers the change.Where Crawlee JS doesn't keep the contract its
pause()documents, this PR keeps it. A repeatedpause()also waits for the tasks in progress. Apause()that comes while the pool awaitsis_task_ready_functionoris_finished_functiondoesn't let a new task start orrun()return.✍️ Drafted by Claude Code