Merged
Conversation
dcantah
force-pushed
the
linux-ci
branch
3 times, most recently
from
14a0f76 to
0e6b951
Compare
To make sure the project (and many linux specific libraries) builds on linux lets add a linux step to build for both musl and glibc. Eventually this will run unit tests as well.
madrob
reviewed
Apr 7, 2026
| name: Linux compile check | ||
| timeout-minutes: 30 | ||
| runs-on: ubuntu-24.04 | ||
| container: swift:6.3-noble |
Contributor
There was a problem hiding this comment.
I would prefer we install swift in the steps so we can programmatically decide what version to install instead of needing to update this container image manually.
Today there's quite a few things that do not compile if you change musl out for glibc. This is either due to type differences between what some of the syscall wrappers expect (enums vs. raw integers) or the fact that swifts glibc modulemap doesn't define gnu_source so some headers don't get included (vfs.h for statfs and pals). To work around this, we need to expose either compatability shims, or just expose the headers we need in our existing c shims we already have.
katiewasnothere
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #606
To make sure the project (and many linux specific libraries) builds on linux lets add a linux step to build for both musl and glibc. Eventually this will run unit tests as well. This change needs a bit more libc agnostic-ifying work to make sure things work for both libcs.