Repository navigation
Conversation
acmcelwee
force-pushed
the
fix-auth-case-sensitivity
branch
2 times, most recently
from
October 22, 2026 19:42
0957317 to
f9961cc
Compare
RFC 9110 §11.1 and §11.2 specify that HTTP authentication schemes and parameter names are case-insensitive tokens. Previously, RegistryClient matched schemes case-sensitively against "Bearer" and "Basic" and looked up parameter keys with their as-received casing, breaking login and pull against registries like Sonatype Nexus that send "WWW-Authenticate: BASIC realm=...". - Lowercase schemes and parameter keys in parseWWWAuthenticateHeaders. - Compare against "bearer" and "basic" in RegistryClient and RegistryClient+Token. - Include the offered schemes in the missing-Bearer error message. - Add unit tests in AuthChallengeTests for uppercase schemes and mixed-case parameter keys, and parameterize the TLS Basic challenge test in RealmRequestTests across Basic, BASIC, and basic. Fixes apple#984
acmcelwee
force-pushed
the
fix-auth-case-sensitivity
branch
from
October 22, 2026 19:45
f9961cc to
1e8e897
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9110 §11.1 and §11.2 specify that HTTP authentication schemes and parameter names are case-insensitive tokens. Previously,
RegistryClientmatched schemes case-sensitively against"Bearer"and"Basic"and looked up parameter keys with their as-received casing, breakingcontainer registry loginandcontainer image pullagainst registries like Sonatype Nexus that sendWWW-Authenticate: BASIC realm="...".RegistryClient.parseWWWAuthenticateHeaders."bearer"and"basic"inRegistryClientandRegistryClient+Token.createTokenRequest.AuthChallengeTestsfor uppercase schemes and mixed-case parameter keys, and parameterize the TLS Basic challenge test inRealmRequestTestsacrossBasic,BASIC, andbasic.Fixes #984