Skip to content

ci: Add initial CI#9

Merged
guru-desh merged 10 commits into
mainfrom
u/g_deshpande/add-github-actions
Jun 24, 2026
Merged

ci: Add initial CI#9
guru-desh merged 10 commits into
mainfrom
u/g_deshpande/add-github-actions

Conversation

@guru-desh

Copy link
Copy Markdown
Contributor

This PR adds an initial GitHub Actions CI.

This configuration does the following:

  1. Stage 1 - Runs make check on MacOS
  2. Stage 2 - Runs test suite
    • Highest PyTorch Fast Tests: Runs on MacOS

This PR also adds a change in pyproject.toml to exclude new packages until they have been on PyPi for more then 7 days. This allows us some security by making sure that the latest wheels are not always being installed.

@guru-desh guru-desh marked this pull request as ready for review June 23, 2026 00:12
@guru-desh guru-desh requested review from aseemw and dengqiaoyu June 23, 2026 17:48
Comment thread .github/workflows/ci.yaml
Comment thread .github/workflows/ci.yaml
@madrob

madrob commented Jun 23, 2026

Copy link
Copy Markdown

I recommend also configuring dependabot to update your GitHub Actions

Comment thread .github/workflows/ci.yaml
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml
Comment thread pyproject.toml Outdated
Comment on lines +180 to +181
exclude-newer = "7 days"
exclude-newer-package = { coreai-core = false, coreai-torch = false }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these two options do for the CI?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't CI related per-say, but I thought it was small enough to include in this PR. I gave a quick summary in the description, but here's a more detailed description

exclude-newer = "7 days" forces uv to install packages that have only been on pypi.org for more than 7 days. It's mainly for security. The hope is that malicious packages that have been uploaded would be taken down within 7 days and that we wouldn't be compromised.

exclude-newer-package = { coreai-core = false, coreai-torch = false } tells uv to exclude the exclude rule for coreai-core and coreai-torch so that we can use the newest releases of coreai-core and coreai-torch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think that make sense, can you add some comments above?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exclude-newer = "7 days" forces uv to install packages that have only been on pypi.org for more than 7 days. It's mainly for security.

What would happen, if we pin a package in the pyproject.toml to a version that is very new. What would take precedence then, this rule or the pin specified in pyproject.toml ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule takes precedence

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case which version would be installed, the most recent below the pinned version?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the pin was >=X.Y.Z or ==X.Y.Z, then a resolution error would occur unless X.Y.Z has been on pypi for more than 7 days

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do need a specific package to be installed and to bypas the exclude-newer rule, we can add the package to exclude-newer-package. This is what we currently do for coreai-torch and coreai-core

dengqiaoyu
dengqiaoyu previously approved these changes Jun 24, 2026

@dengqiaoyu dengqiaoyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for setting it up!

@guru-desh guru-desh force-pushed the u/g_deshpande/add-github-actions branch from 31a5caa to 6817ac9 Compare June 24, 2026 22:33
dengqiaoyu
dengqiaoyu previously approved these changes Jun 24, 2026
dengqiaoyu
dengqiaoyu previously approved these changes Jun 24, 2026
@guru-desh guru-desh force-pushed the u/g_deshpande/add-github-actions branch from 746c15c to 6817ac9 Compare June 24, 2026 22:47
dengqiaoyu
dengqiaoyu previously approved these changes Jun 24, 2026
@guru-desh guru-desh force-pushed the u/g_deshpande/add-github-actions branch from 8ac153a to 6817ac9 Compare June 24, 2026 22:56
@guru-desh guru-desh merged commit b87471b into main Jun 24, 2026
5 of 8 checks passed
@guru-desh guru-desh mentioned this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants