ci: Add initial CI#9
Conversation
|
I recommend also configuring dependabot to update your GitHub Actions |
| exclude-newer = "7 days" | ||
| exclude-newer-package = { coreai-core = false, coreai-torch = false } |
There was a problem hiding this comment.
What do these two options do for the CI?
There was a problem hiding this comment.
These aren't CI related per-say, but I thought it was small enough to include in this PR. I gave a quick summary in the description, but here's a more detailed description
exclude-newer = "7 days" forces uv to install packages that have only been on pypi.org for more than 7 days. It's mainly for security. The hope is that malicious packages that have been uploaded would be taken down within 7 days and that we wouldn't be compromised.
exclude-newer-package = { coreai-core = false, coreai-torch = false } tells uv to exclude the exclude rule for coreai-core and coreai-torch so that we can use the newest releases of coreai-core and coreai-torch
There was a problem hiding this comment.
Thanks! I think that make sense, can you add some comments above?
There was a problem hiding this comment.
exclude-newer = "7 days" forces uv to install packages that have only been on pypi.org for more than 7 days. It's mainly for security.
What would happen, if we pin a package in the pyproject.toml to a version that is very new. What would take precedence then, this rule or the pin specified in pyproject.toml ?
There was a problem hiding this comment.
The rule takes precedence
There was a problem hiding this comment.
In that case which version would be installed, the most recent below the pinned version?
There was a problem hiding this comment.
If the pin was >=X.Y.Z or ==X.Y.Z, then a resolution error would occur unless X.Y.Z has been on pypi for more than 7 days
There was a problem hiding this comment.
If we do need a specific package to be installed and to bypas the exclude-newer rule, we can add the package to exclude-newer-package. This is what we currently do for coreai-torch and coreai-core
dengqiaoyu
left a comment
There was a problem hiding this comment.
Thank you for setting it up!
31a5caa to
6817ac9
Compare
746c15c to
6817ac9
Compare
8ac153a to
6817ac9
Compare
This PR adds an initial GitHub Actions CI.
This configuration does the following:
make checkon MacOSThis PR also adds a change in
pyproject.tomlto exclude new packages until they have been on PyPi for more then 7 days. This allows us some security by making sure that the latest wheels are not always being installed.