Open
Conversation
- authorize and secrets are gone, ASnake auth with default values assumed for now - places where json is built up as raw strings replaced with json.dumps (filter queries) - rather than using data=json.dumps(thing), json=thing has been preferred - some whitespace changes standardizing on 4-space tab stops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of a rough pass, and I did a few other changes which are doc'd in the commit message.
Overall, it's not a big change - it's all using the client, which just mainly handles baseurl, auth, and paging for one.
It's not tested yet - I'm putting this up more for you to look at than to merge, if that makes sense? Please let me know if you have any issues/comments!