fix(pds): Remove empty collections from cache on record delete#157
Merged
ascorbic merged 7 commits intoMay 12, 2026
Merged
Conversation
commit: |
ascorbic
reviewed
May 4, 2026
Owner
ascorbic
left a comment
There was a problem hiding this comment.
Actually, I realise this should also be applied to rpcApplyWrites, because that can also be used to delete records (and is in fact the more common way)
Mirror the rpcDeleteRecord fix for the more common deletion path: applyWrites batches that empty a collection now drop the cache entry. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
Author
Ah okay, good point. Pushed a new commit that includes this change + tests. |
…pty-collections # Conflicts: # packages/pds/src/account-do.ts
ascorbic
approved these changes
May 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectionscache, sodescribeRepokept reporting empty collections.${collection}/prefix and call a newSqliteRepoStorage.removeCollection()if no records remain in that collection.rpcDeleteRecordintegration (last-record removal vs. records-remaining retention).Test plan
pnpm --filter @getcirrus/pds testpasses (249 tests)describeRepostops listing a collection after deleting its final record🤖 Generated with Claude Code