feat: add krypton codename to utils.sh#433
Open
Codesleuth wants to merge 1 commit intoasdf-vm:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Node.js 24 LTS codename in .nvmrc files by adding the krypton:24 mapping to the codename resolution array.
Key Changes:
- Added
krypton:24entry to thenodejs_codenamesarray inlib/utils.sh
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@augustobmoura can you review this one? Looks good to me... |
|
Node 24 has been out since May of 2025 and has been an active LTS version since October... why is this not yet incorporated into the asdf plugin yet? This is quite frustrating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the
lts/kyptoncodename in.nvmrcfiles by adding thekryptoncodename to the list.In case of ambiguity here, see: https://nodejs.org/en/download/archive/v24.11.0