refactor(askui): delegate controller path to askui-agent-os package#246
Merged
mlikasam-askui merged 3 commits intomainfrom Mar 19, 2026
Merged
refactor(askui): delegate controller path to askui-agent-os package#246mlikasam-askui merged 3 commits intomainfrom
mlikasam-askui merged 3 commits intomainfrom
Conversation
- Add askui-agent-os>=26.2.1 dependency - Replace custom controller path resolution (component registry, installation directory, ASKUI_CONTROLLER_PATH) with AgentOS.controller_path() - Remove deprecated installation_directory and related settings - Simplify AskUiControllerSettings and trim unit tests to match
Collaborator
programminx-askui
left a comment
programminx-askui
left a comment
There was a problem hiding this comment.
Let's have a talk about the overall concept.
| pip install askui | ||
| ``` | ||
|
|
||
| ## AgentOS Installation |
Collaborator
There was a problem hiding this comment.
We need to talk about how we want to communicate the AgentOS installer
Collaborator
There was a problem hiding this comment.
Remark: @programminx-askui need to decide how to communicate the AgentOS Installer
programminx-askui
approved these changes
Mar 18, 2026
| pip install askui | ||
| ``` | ||
|
|
||
| ## AgentOS Installation |
Collaborator
There was a problem hiding this comment.
Remark: @programminx-askui need to decide how to communicate the AgentOS Installer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delegate AskUI Remote Device Controller path resolution to the
askui-agent-ospackage instead of implementing it in the sdk repo.Changes
askui-agent-os>=26.1.1inpyproject.toml.component_registry_file,installation_directory, andcontroller_path_setting(and related env vars).controller_pathasAgentOS.controller_path()fromaskui-agent-os.controller_argsand settings that still exist.Motivation
askui-agent-os.