Skip to content

Add authentication support to Net::HTTP.SOCKSProxy#24

Closed
ojab wants to merge 2 commits into
astro:masterfrom
ojab:master
Closed

Add authentication support to Net::HTTP.SOCKSProxy#24
ojab wants to merge 2 commits into
astro:masterfrom
ojab:master

Conversation

@ojab

@ojab ojab commented Sep 3, 2015

Copy link
Copy Markdown

No description provided.

@astro

astro commented Sep 4, 2015

Copy link
Copy Markdown
Owner

Cool, thank you. Please ping the new maintainer @musybite if nothing happens for a few days.

@ojab

ojab commented Nov 30, 2015

Copy link
Copy Markdown
Author

ping @musybite

@musybite

musybite commented Dec 7, 2015

Copy link
Copy Markdown
Collaborator

Thank you for pull request @ojab and sorry for long silence. Everything looks good to me. I'll make release this weekend.

@ojab

ojab commented Dec 7, 2015

Copy link
Copy Markdown
Author

Thanks!

@ojab ojab force-pushed the master branch 2 times, most recently from 6fa4fcd to f604bcf Compare December 8, 2015 11:19
@ojab

ojab commented Dec 8, 2015

Copy link
Copy Markdown
Author

I've rebased PR #22 on current master (1.7.0) and put patch for this PR on top, please let me know if something should be changed.

@mikecmpbll mikecmpbll mentioned this pull request Dec 9, 2015
Merged
@mikecmpbll

mikecmpbll commented Sep 8, 2016

Copy link
Copy Markdown

@musybite I wonder if this will be merged & released?

@mikecmpbll mikecmpbll mentioned this pull request Jan 23, 2017
Open
@ajimix

ajimix commented Jul 12, 2017 •
edited
Loading

Copy link
Copy Markdown

@musybite @astro any way that this can be merged? thanks!

musybite added a commit that referenced this pull request Mar 13, 2018
@musybite
Add authentication support to Net::HTTP.SOCKSProxy
dae6100 
Inspired by #24. This version does not require thread-local variables,
everything kept inside instance and local variables.

Thanks @ojab!
@musybite musybite mentioned this pull request Mar 13, 2018
Merged
@musybite

musybite commented Mar 13, 2018

Copy link
Copy Markdown
Collaborator

@ojab @ajimix @mikecmpbll i'd proposed another implementation in MR #33. API is fully the same. Could you check whether it works for you?

I have certain doubts about switching from class @@-variables to thread-local variables: for example, it will definitely break socksify_ruby script for multi-threaded apps, and could lead to other unintended consequences. From the very beginning, socksify implied "global socksification" of whole application with all its threads, and thread-safe (albeit somewhat ugly) APIs were added only recently. For such old and stable project as socksify, it is important not to break compatibility.

@ojab

ojab commented Mar 14, 2018

Copy link
Copy Markdown
Author

I don't use socksify any more, so unfortunately I can't test this change.

@MatzFan MatzFan mentioned this pull request Jul 4, 2022
Closed
astro pushed a commit that referenced this pull request Jul 9, 2025
@musybite @astro
Add authentication support to Net::HTTP.SOCKSProxy
2fd0fc3 
Inspired by #24. This version does not require thread-local variables,
everything kept inside instance and local variables.

Thanks @ojab!
astro pushed a commit that referenced this pull request Jul 9, 2025
@musybite @astro
Add authentication support to Net::HTTP.SOCKSProxy
4af5542 
Inspired by #24. This version does not require thread-local variables,
everything kept inside instance and local variables.

Thanks @ojab!
@MatzFan

MatzFan commented Jul 12, 2025

Copy link
Copy Markdown
Collaborator

Superseded by ca69e45

@MatzFan MatzFan closed this Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ojab @astro @musybite @mikecmpbll @ajimix @MatzFan @jakemack