fix: harden returnTo validation against control-character open redirect - #35
Open
yogeshchoudhary147 wants to merge 1 commit into
Open
fix: harden returnTo validation against control-character open redirect#35yogeshchoudhary147 wants to merge 1 commit into
yogeshchoudhary147 wants to merge 1 commit into
Conversation
yogeshchoudhary147
force-pushed
the
fix/open-redirect-control-char-bypass
branch
from
August 27, 2026 02:52
a7074ed to
845ad1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isSafeRelativeUrlused a block-list (//,/\) that missed ASCII control characters (TAB 0x09, LF 0x0A, CR 0x0D) — payloads like/%09/evil.compassed validation but browsers strip the control character, turning it into//evil.com(protocol-relative open redirect)options.returnToin bothhandleLoginandhandleCallback, which previously reached their sinks unvettedoptions.returnToin both handlersTest plan
npm testpasses (351 tests)npm run typecheckpasses?returnTo=/%09/evil.comfalls back to/instead of redirecting off-site?returnTo=/%0a/evil.comand?returnTo=/%0d/evil.comfall back to/?returnTo=//evil.comand?returnTo=/\evil.comcontinue to be rejected/dashboardand/settings?tab=1continue to work