updating rds.DatabaseInstanceSourceProps to use credentials#20
Open
arozar wants to merge 1 commit intoaws-samples:rodafrom
Open
updating rds.DatabaseInstanceSourceProps to use credentials#20arozar wants to merge 1 commit intoaws-samples:rodafrom
arozar wants to merge 1 commit intoaws-samples:rodafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently the Typescript is no longer compiling.
This is due to the fact the the rds.DatabaseInstanceProps interface now uses a credentials property rather than a username and password properties.
Have tested by doing the following:
Am not able to make this PR to the master branch as the bindingdb stack is not in that branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.