Fixing KeyError in script for activating glue triggers#23
Open
nchylak wants to merge 5 commits intoaws-samples:mainlinefrom
Open
Fixing KeyError in script for activating glue triggers#23nchylak wants to merge 5 commits intoaws-samples:mainlinefrom
nchylak wants to merge 5 commits intoaws-samples:mainlinefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMMIT a24c1b8
Issue #, if available:
n/a
Description of changes:
The lambda function was failing to activate the Glue triggers created due to a KeyError. Key should be
triggerId(and notTriggerId) as specified in the properties of the three custom resources created in data-set-enrollment.ts.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
COMMIT 6944b01
Issue #, if available:
n/a
Description of changes:
The property name used for creating the managed policy was not correct (
policyNameinstead ofmanagedPolicyName, see doc). As a result, the stack could still be deployed but the name of the managed policy was not applied.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.