fix: allow stackName to change#70
Open
scottschreckengaust wants to merge 7 commits intomainfrom
Open
Conversation
Signed-off-by: bgagent <scottschreckengaust@users.noreply.github.com>
Contributor
Author
|
Upon trial:
cdk/src/stacks/agent.ts — need these 3 changes:
cdk/src/constructs/agent-memory.ts — 2 changes:
cdk/test/constructs/agent-memory.test.ts — test updated:
|
Each resource with a name uniqueness constraint now truncates to its
own API limit, removing the need for a central stackName length check:
- Guardrail: ${stackName}-guardrail (.slice(0, 50))
- Memory: mem_${stackName} (.slice(0, 48))
- Runtime: sanitize + .slice(0, 48), ensure starts with letter
- Model invocation logging: remove onDelete (account-level singleton)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Slack verification test uses 'test-signing-secret-abc123' which triggers gitleaks generic-api-key rule. Not a real credential. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Tested in AWS Account in one region for successful deployment in one region (functional testing not performed - just deployment to stacks with unique resources) |
The default memory name changed from `mem_` to `bgagent_memory_` prefix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multi-stack name collisions by making each resource self-guard its own name length, rather than imposing a central
stackNamelength limit.Problem
Deploying a second named stack (e.g.
commit-fa647ca...) in the same account fails because several resources use hardcoded names with account-level uniqueness:task-input-guardrail(per-account per-region unique)bgagent_memory(per-account per-region unique)jean_cloude(per-account per-region unique)onDeletein one stack disables logging for all stacksFix
stackName→ sanitize non-alphanumeric to_, ensure starts with letter.slice(0, 48)${stackName}-guardrail.slice(0, 50)mem_${stackName}(sanitized).slice(0, 48)onDelete— account-level singleton shouldn't be torn down by one stackThe 40-character
stackNameinput validation is removed — each resource truncates to its own API limit independently.Also included
test-signing-secret-abc123in Slack verification test was triggering false positiveTest plan
mise //cdk:compilepassesmise //cdk:test— 1170 tests pass, 68 suites🤖 Generated with Claude Code