[fix]: bugfix for when use custom domain and execute docker push issue#23
Open
geniousli wants to merge 15 commits intoaws-samples:support-private-hostfrom
Open
[fix]: bugfix for when use custom domain and execute docker push issue#23geniousli wants to merge 15 commits intoaws-samples:support-private-hostfrom
geniousli wants to merge 15 commits intoaws-samples:support-private-hostfrom
Conversation
add documentation for supporting private host dns
This reverts commit 6872f52.
update orchistrator
Co-authored-by: cloud456 <tzq@b0be834a7d8a.ant.amazon.com>
Author
|
@dashjim @AdnaneKhan @teaguexiao can anyone help to check this issue and Pr |
geniousli
changed the base branch from
feat/update-to-new
to
support-private-host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: when i use the package/docker-reverse-proxy 's aws ecr registry impl, and use docker push to docker-reverse-proxy， it not work as expect. and i find the docker always report "unauth" error, and i found the docker-reverse proxy not correct change location's value.
Description of changes:
i changed the response's location to docker-reverse-proxy's location, so docker push can work continue.